Get weights for roboto mono #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Thanks for looking into this!
It looks good but we are hitting dotnet/fsharp#16014 in the main branch.
Removing
Line 4 in 27cb3f2
|
@nojaf I also added quotes to build.fsx so that it would work with spaces in the build path (dotnet fsi build.fsx used to fail on my PC). |
|
Thanks, I'm afraid the Aslo removing |
|
Looks good here, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like firefox works if I explicitly request fonts with weights used in code snippets. Fixes #850 and fixes dotnet/fsharp#16072
Screenshot of correct spacing in firefox with 600 weight (albeit with an aged local version of fsharp-core-docs):